fix: canvas preview panic in Xcode resolved #82
Merged
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I8d6a19063a13f772dc409bc5e523e1af9c109bee Signed-off-by: Thomas Kosiewski <[email protected]>
ethanndickson
approved these changes
Feb 27, 2025
| @@ -25,6 +25,7 @@ class AppState: ObservableObject { | |||
| // Stored in Keychain | |||
| @Published private(set) var sessionToken: String? { | |||
| didSet { | |||
| guard persistent else { return } | |||
There was a problem hiding this comment.
This is already guarded in keychainSet
There was a problem hiding this comment.
Oh yes, it would have been wise of me to check that. 😅
I will keep it in for consistency with the setters above and below, as it appeared somewhat odd. This also ensures that we are doubly safe.
deansheather
deleted the
thomask33/02-26-fix_canvas_preview_panic_in_xcode_resolved
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preview was panicking because the app state had an optional base URL, which is getting unwrapped elsewhere. This creates an app state and then 'logs in' to set the base URL, reenabling the preview.
Change-Id: I8d6a19063a13f772dc409bc5e523e1af9c109bee
Signed-off-by: Thomas Kosiewski [email protected]